Update check-jupyter-wip.yml

STRIDES · Nov 19, 2024 · 023cd4c · 023cd4c
1 parent 9b4c193
commit 023cd4c
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/.github/workflows/check-jupyter-wip.yml b/.github/workflows/check-jupyter-wip.yml
@@ -1,4 +1,4 @@
-name: Test run with nbconvert
+name: Testing notebooks with nbmake
 
 on:
   workflow_dispatch: 
@@ -29,9 +29,17 @@ jobs:
         ## Later move the above to a requrements.txt and run the below
         ## pip install -r requirements.txt 
 
+    - name: Setup required variables
+      env:
+        NOTEBOOK_GCP_PROJECT_ID: ${{ secrets.NOTEBOOK_GCP_PROJECT_ID }}
+        NOTEBOOK_GCP_LOCATION: ${{ secrets.NOTEBOOK_GCP_LOCATION }}
+      run: |
+        echo "NOTEBOOK_GCP_PROJECT_ID=${NOTEBOOK_PROJECT_ID}" >> $GITHUB_ENV
+        echo "NOTEBOOK_GCP_LOCATION=${NOTEBOOK_GCP_LOCATION}" >> $GITHUB_ENV
+        
     - name: Test notebook
       run: |
         pwd
         #jupyter nbconvert --to notebook --execute notebooks/GenAI/Gemini_Intro.ipynb
-        pytest --nbmake notebooks/GenAI/Gemini_Intro.ipynb
+        pytest --nbmake notebooks/GenAI/Gemini_Intro.ipynb --variable-file=env.json