use obj.id_ instead of obj.id

[benjaminxscott]

As reported by @NikkiEllis during integration testing in chantilly

edit: This change breaks round-tripping - will defer on merging until CI is cleared

[gtback]

I don't think this should get merged as is. There's too much existing code it would break.

I'll take full blame for using id_ rather than id. I was originally trying to prevent conflicts with all Python built-ins, not just reserved words (class, for, from, etc.). More discussion in #234.

If there's a way to make id and id_ both reference the same variable, that would be fine:

@property
def id(self):
    return self.id_

@id.setter
def id(self, value):
    self.id_ = value

(WARNING: I just typed that code in without testing it at all, so no guarantees it works 😉)

[gtback]

I misunderstood this PR. We shouldn't be messing with the binding objects (switching id to id_) unless there are bugs in the bindings. It's possible that for consistency we should allow using id at the API layer in addition to id_ (which is what my earlier comment was describing), but at this point I don't think that's a high priority.