Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix test_008_wildcardsearch for RHEL10 #7821

Closed
wants to merge 1 commit into from

Conversation

aborah-sudo
Copy link
Contributor

@aborah-sudo aborah-sudo commented Feb 4, 2025

Fix test_008_wildcardsearch for RHEL10

Non working filter: conv_text = 'tshark -r %s -R ldap.filter -V -2 > /tmp/automount.txt' % (auto_pcapfile)
There is 'test_infopipe__list_by_attr' system test that searches by wildcard so functionality is covered.

@alexey-tikhonov
Copy link
Member

No explanation provided.

@aborah-sudo aborah-sudo force-pushed the remove branch 2 times, most recently from ba03eba to e7af04e Compare February 5, 2025 06:34
@aborah-sudo aborah-sudo changed the title Tests: Remove test_008_wildcardsearch for RHEL10 Tests: Fix test_008_wildcardsearch for RHEL10 Feb 5, 2025
@aborah-sudo
Copy link
Contributor Author

@jakub-vavra-cz and @alexey-tikhonov :

From RHel10 tcpdump does not contain any info the test is looking for. So i have lead the search file to doman.log which is wrorking fine there .

@alexey-tikhonov
Copy link
Member

From RHel10 tcpdump does not contain any info the test is looking for.

Why?

@aborah-sudo
Copy link
Contributor Author

From RHel10 tcpdump does not contain any info the test is looking for.

Why?

Please check automount9.txt has everything but automount10.txt does not contain any valuable info .

automount9.txt
automount10.txt

@alexey-tikhonov
Copy link
Member

automount10.txt does not contain any valuable info

Why?

'sssd_be' on RHEL10 still talks to LDAP server via network.
So please find the reason tcpdump log (presumably) doesn't contain trace of this communication.

@aborah-sudo
Copy link
Contributor Author

automount10.txt does not contain any valuable info

Why?

'sssd_be' on RHEL10 still talks to LDAP server via network. So please find the reason tcpdump log (presumably) doesn't contain trace of this communication.

Looks like these are encrypted not valuable after converting to human readable format

@alexey-tikhonov
Copy link
Member

automount10.txt does not contain any valuable info

Why?
'sssd_be' on RHEL10 still talks to LDAP server via network. So please find the reason tcpdump log (presumably) doesn't contain trace of this communication.

Looks like these are encrypted not valuable after converting to human readable format

Try with 'ldap_id_use_start_tls = false' in the domain section of sssd.conf

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz
Copy link
Contributor

BTW: @alexey-tikhonov Dropping a legacy test that no longer works when the functionality is covered elsewhere is fully aligned with the clean sweep plan to reduce maintenace workload. The only thing that was missing in the initial commit message was a proper explanation why we want to drop it and where is the wild-card search covered.

@alexey-tikhonov
Copy link
Member

Dropping a legacy test that no longer works when the functionality is covered elsewhere is fully aligned

I asked about a replacement as a one of first things and got no response.

@alexey-tikhonov
Copy link
Member

@aborah-sudo , please update the commit message.

@aborah-sudo
Copy link
Contributor Author

@aborah-sudo , please update the commit message.

Done

@alexey-tikhonov
Copy link
Member

Awaiting CI results.

@alexey-tikhonov
Copy link
Member

FAIL: src/tests/whitespace_test

Communication between client and master is encripted we have to set "ldap_start_tls = Failse" to make the communication human readable
@aborah-sudo
Copy link
Contributor Author

FAIL: src/tests/whitespace_test

this issue is gone now

@alexey-tikhonov
Copy link
Member

Pushed PR: #7821

  • master
    • fdf0b50 - Tests: Fix test_008_wildcardsearch for RHEL10
  • sssd-2-10
    • c6d7ba0 - Tests: Fix test_008_wildcardsearch for RHEL10

@aborah-sudo aborah-sudo deleted the remove branch February 10, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants