-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize sssctl tests 1. #7801
Open
dkarpele
wants to merge
1
commit into
SSSD:master
Choose a base branch
from
dkarpele:dkarpele-param-sssctl-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpick, LG2M
e952fa8
to
98a6736
Compare
danlavu
approved these changes
Jan 20, 2025
Can you squash the commits? |
98a6736
to
2d55c41
Compare
yep |
94779df
to
f3125dc
Compare
alexey-tikhonov
approved these changes
Jan 29, 2025
f3125dc
to
18ad4d7
Compare
- Combine various sssctl tests to the single parametrized tests. test_sssctl__check_invalid_option_name_in_snippet merges tests: test_sssctl__check_invalid_option_name_in_snippet test_sssctl__check_invalid_section_in_name_in_snippet Signed-off-by: Denis Karpelevich <[email protected]>
18ad4d7
to
bf3b18b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sssctl__check_invalid_option_name_in_snippet merges tests:
test_sssctl__check_invalid_option_name
test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet