Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize sssctl tests 1. #7801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkarpele
Copy link
Contributor

@dkarpele dkarpele commented Jan 18, 2025

  • Combine various sssctl tests to the single parametrized tests.

test_sssctl__check_invalid_option_name_in_snippet merges tests:

test_sssctl__check_invalid_option_name
test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpick, LG2M

src/tests/system/tests/test_sssctl.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_sssctl.py Outdated Show resolved Hide resolved
@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from e952fa8 to 98a6736 Compare January 20, 2025 17:27
@dkarpele dkarpele requested a review from danlavu January 20, 2025 17:31
@danlavu
Copy link

danlavu commented Jan 20, 2025

Can you squash the commits?

@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from 98a6736 to 2d55c41 Compare January 20, 2025 19:25
@dkarpele
Copy link
Contributor Author

yep

@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch 2 times, most recently from 94779df to f3125dc Compare January 28, 2025 17:50
@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from f3125dc to 18ad4d7 Compare January 31, 2025 15:33
- Combine various sssctl tests to the single parametrized tests.

test_sssctl__check_invalid_option_name_in_snippet merges tests:
test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet

Signed-off-by: Denis Karpelevich <[email protected]>
@dkarpele dkarpele force-pushed the dkarpele-param-sssctl-1 branch from 18ad4d7 to bf3b18b Compare February 9, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants