Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: authentication, adding override_homedir tests #7682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danlavu
Copy link

@danlavu danlavu commented Nov 4, 2024

  • moving ad specific test out of authentication and to it's own file

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

src/tests/system/tests/test_ad.py Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
home_fmt, home_exp = home_map[home_key]
client.sssd.domain["homedir_substring"] = "/home/homedir"
client.sssd.domain["override_homedir"] = home_fmt
client.sssd.stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a method to do stop/clear/start as we had in the old pytests.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/tests/system/tests/test_ad.py Show resolved Hide resolved
src/tests/system/tests/test_authentication.py Outdated Show resolved Hide resolved
* moving ad specific test out of authentication and to it's own file
@danlavu
Copy link
Author

danlavu commented Nov 5, 2024

The tests are going to fail, now this PR depends on SSSD/sssd-test-framework#136

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants