Get rid of on-house MIN/MAX definitions

This matches approach already taken in sss_client/idmap/sss_nss_ex.c Reviewed-by: Sumit Bose <[email protected]>
SSSD · Oct 17, 2024 · b928dbe · b928dbe
1 parent cbe3b03
commit b928dbe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 20 deletions.
diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c
@@ -33,10 +33,6 @@
 #define DB_CACHE_EXPIRE "dataExpireTimestamp"
 #define DB_OC "objectCategory"
 
-#ifndef MAX
-#define MAX(a,b) (((a) > (b)) ? (a) : (b))
-#endif
-
 struct mbof_val_array {
     struct ldb_val *vals;
     int num;

diff --git a/src/util/safe-format-string.c b/src/util/safe-format-string.c
@@ -33,19 +33,13 @@
 
 #include "config.h"
 
-#include "safe-format-string.h"
-
+#include <sys/param.h> /* for MIN() */
 #include <errno.h>
 #include <stdarg.h>
 #include <string.h>
 
-#ifndef MIN
-#define MIN(a, b)  (((a) < (b)) ? (a) : (b))
-#endif
+#include "safe-format-string.h"
 
-#ifndef MAX
-#define MAX(a, b)  (((a) > (b)) ? (a) : (b))
-#endif
 
 static void
 safe_padding (int count,

diff --git a/src/util/util.h b/src/util/util.h
@@ -34,6 +34,7 @@
 #include <limits.h>
 #include <sys/un.h>
 #include <sys/capability.h>
+#include <sys/param.h> /* for MIN()/MAX() */
 
 #include <talloc.h>
 #include <tevent.h>
@@ -79,14 +80,6 @@
 #define NULL 0
 #endif
 
-#ifndef MIN
-#define MIN(a, b)  (((a) < (b)) ? (a) : (b))
-#endif
-
-#ifndef MAX
-#define MAX(a, b)  (((a) > (b)) ? (a) : (b))
-#endif
-
 #ifndef ALLPERMS
 #define ALLPERMS (S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO)/* 07777 */
 #endif