-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #104
Open
jalelgaming
wants to merge
1
commit into
junior_testing
Choose a base branch
from
teensy_junior
base: junior_testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tests #104
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,65 @@ | ||
#ifdef #ifdef __MK20DX256__ // Teensy Compile | ||
#ifndef TEENSYFUNCTIONS_H | ||
#define TEENSYFUNCTIONS_H | ||
|
||
#include "ButtonFlag.h" | ||
//Teensy PC safe versions | ||
//Controller.cpp | ||
|
||
extern volatile bool buttonFlag; | ||
|
||
#ifdef __MK20DX256__ // Teensy Compile | ||
#else //on windows | ||
void delay(int milliseconds){}; | ||
void delay(unsigned long milliseconds){}; | ||
#endif | ||
|
||
#ifdef #ifdef __MK20DX256__ // Teensy Compile | ||
#ifdef __MK20DX256__ // Teensy Compile | ||
#else //on windows | ||
void digitalWrite(int pin, bool high){}; | ||
#endif | ||
|
||
//The above definitions already complete | ||
//Line 237 | ||
//Line 263 | ||
//Line 273 | ||
//Line 287 | ||
|
||
//Line 301 | ||
#ifdef __MK20DX256__ // Teensy Compile | ||
#else | ||
void cli(){}; | ||
|
||
if (!buttonFlag) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can't have an if statement that is not part of a function |
||
{ | ||
buttonFlag = true; | ||
} | ||
|
||
void sei(){}; | ||
#endif | ||
|
||
//Line 316 | ||
#ifdef __MK20DX256__ // Teensy Compile | ||
#else | ||
void pinMode(int pin, bool mode){}; | ||
void attachInterrupt(int pin, bool mode){}; | ||
#endif | ||
|
||
//IRSensor.cpp | ||
//Line 6 | ||
#ifdef __MK20DX256__ // Teensy Compile | ||
#else | ||
#include <iostream> | ||
#endif | ||
|
||
//Line 48 already done | ||
//Line 151 as well | ||
//Line 201 -- pinMode (here on line 41) may fix it | ||
|
||
//Logger.h | ||
//Line 3 already done | ||
//Line 57 as well | ||
//Line 113 as well | ||
//Line 123 as well | ||
//Line 138 -- | ||
//Line 151 done | ||
//Line 177 done | ||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the functions actually need to be static as well, my bad. This is to prevent any linker problems during compiling
static void delay(unsigned long milliseconds){};
all of them need to be static