feat(DPE-35): Created Collections rules #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sps-benjacobs
changed the title
sps-benjacobs
changed the title
brandonsahadeo
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Added some considerations. Also, I'm a bit worried about making too many assumptions about endpoints being collections. What is the impact seen on specifically network API related specs for these? like Documents / Items / Printables? (sps-missing-pagination-query-parameters and sps-no-collection-paging-capability)
|
Here are the results of the Summary of performance testing:
Here are the results of the Summary of Impact testing:
This resulted in 16 new errors.
|
…paging-capability to warnings instead of errors
…ify the new behavior
brandonsahadeo
approved these changes
Aug 8, 2024
markdebeer
requested changes
Aug 8, 2024
rulesets/test/collections/sps-hybird-filtering-exists-with-root-filter.test.js
Outdated
Show resolved
Hide resolved
rulesets/test/collections/sps-hybird-filtering-exists-with-root-filter.test.js
Outdated
Show resolved
Hide resolved
rulesets/test/collections/sps-hybird-filtering-exists-with-root-filter.test.js
Outdated
Show resolved
Hide resolved
…t-filter.test.js Co-authored-by: Mark DeBeer <[email protected]> Signed-off-by: Ethan Honzik <[email protected]>
…t-filter.test.js Co-authored-by: Mark DeBeer <[email protected]> Signed-off-by: Ethan Honzik <[email protected]>
…t-filter.test.js Co-authored-by: Mark DeBeer <[email protected]> Signed-off-by: Ethan Honzik <[email protected]>
markdebeer
approved these changes
Aug 12, 2024
SPSCommerce-VSTS-BOT
pushed a commit
that referenced
this pull request
Aug 12, 2024
# [1.13.0](v1.12.0...v1.13.0) (2024-08-12) ### Features * **DPE-35:** Created Collections rules ([#86](#86)) ([1ad59f3](1ad59f3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact testing results are about 8 more errors in total. The execution time for the impact testing is within a second or so compared to the current ruleset in the main branch.
Performance testing results are okay. These changes will create about 700 more errors or warnings within this Open API document suite we use. About 564 of those 700 errors/warnings are mainly concentrated in a few documents. The two rules
sps-missing-pagination-query-parametersandsps-no-collection-paging-capabilityare the ones that are causing the most errors since not all GET endpoints are not designed with collections capabilities. Execution time is still within a second or so of the current ruleset on the main branch.