Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dpe 135): naming rules #85

Merged
merged 38 commits into from
Jul 17, 2024
Merged

feat(Dpe 135): naming rules #85

merged 38 commits into from
Jul 17, 2024

Commits on Apr 15, 2024

  1. Initial rule changes for naming

    @brandonsahadeo
    brandonsahadeo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    22ceb30 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. updated sps-camel-case-properties to use built in spectral functional… 

    …ity, added sps-disallowed-prepositions rule
    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1fa9a1b View commit details
    Browse the repository at this point in the history

  2. added tsconfig

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    59f6a50 View commit details
    Browse the repository at this point in the history

  3. removed sps-invalid-orgref-type

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    40298f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. added tsconfig and jest types

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ee1a0cc View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. added tests and updated naming ruleset

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    55a7699 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. all rules complete, ref-property-name is failing though

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bcbfd77 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. updated markdown with links

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e7c2a30 View commit details
    Browse the repository at this point in the history

  2. updated tests to be more robust

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bdd980a View commit details
    Browse the repository at this point in the history

  3. fixed malformed yaml

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1bda57d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. actualy deleted the package-lock this time

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2475f23 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Update spectral-test-harness.js 

    Signed-off-by: Ethan Honzik <[email protected]>
    @EthanHonzikSPS
    EthanHonzikSPS authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7224f57 View commit details
    Browse the repository at this point in the history

  2. Update spectral-test-harness.js 

    Signed-off-by: Ethan Honzik <[email protected]>
    @EthanHonzikSPS
    EthanHonzikSPS authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    44c7d91 View commit details
    Browse the repository at this point in the history

  3. Delete rulesets/tsconfig.json 

    Out of scope for PR

Signed-off-by: Ethan Honzik <[email protected]>
    @EthanHonzikSPS
    EthanHonzikSPS authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ef5455c View commit details
    Browse the repository at this point in the history

  4. updated docs

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2ed9824 View commit details
    Browse the repository at this point in the history

  5. updated rulesets

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c137a47 View commit details
    Browse the repository at this point in the history

  6. fixed broken formatting

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    446f7b4 View commit details
    Browse the repository at this point in the history

  7. moved tags

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d576628 View commit details
    Browse the repository at this point in the history

  8. fixed typo

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    adf48b8 View commit details
    Browse the repository at this point in the history

  9. updated test descriptions

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5854368 View commit details
    Browse the repository at this point in the history

  10. fixed incorrect test description

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    540b185 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. updated camel case to warning, added more dissalowed prefixes

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a0e6eb7 View commit details
    Browse the repository at this point in the history

  2. updated test for boolean prefix

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    071fd46 View commit details
    Browse the repository at this point in the history

  3. removed rule mandating ref abbreviation

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7e915ed View commit details
    Browse the repository at this point in the history

  4. ensured strict kebab case conformance for rule names

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f8daf23 View commit details
    Browse the repository at this point in the history

  5. updated rule name to use kebab case

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e92244b View commit details
    Browse the repository at this point in the history

  6. Delete rulesets/tsconfig.json 

    Removed accidentally committed tsconfig.json, out of scope for this PR

Signed-off-by: Ethan Honzik <[email protected]>
    @EthanHonzikSPS
    EthanHonzikSPS authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ce3b373 View commit details
    Browse the repository at this point in the history

  7. removed some keywords that are commonly used

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    18f641d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'DPE-135-naming-rules' of https://github.com/SPSCommerce… 

    …/sps-api-standards into DPE-135-naming-rules
    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0a557d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. updated documentation to reflect camel case being a warning

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    965b4a9 View commit details
    Browse the repository at this point in the history

  2. removed tsconfig

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    78fdab5 View commit details
    Browse the repository at this point in the history

  3. fixed exception that occurs when the type field is missing from a pro… 

    …perty
    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    efb6d94 View commit details
    Browse the repository at this point in the history

  4. allow digits in property names

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    37ebd1d View commit details
    Browse the repository at this point in the history

  5. allowed digits and updated camel case back to error as this got rid o… 

    …f most errors
    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3932bc8 View commit details
    Browse the repository at this point in the history

  6. updated naming.md

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32b6ab3 View commit details
    Browse the repository at this point in the history

  7. updated tests to validate error again

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c08b1ee View commit details
    Browse the repository at this point in the history

  8. updated tests to test numbers in camel casing

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    500795a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. merged main

    @EthanHonzikSPS
    EthanHonzikSPS committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e969d9f View commit details
    Browse the repository at this point in the history