#13211 - Update case when person's condition is set to "Dead" or "Bur… #13249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13249 |
leventegal-she
requested changes
Jan 29, 2025
| @@ -49,7 +49,13 @@ protected AbstractBaseEjb(Class<ADO> adoClass, Class<DTO> dtoClass, SRV service) | |||
|
|
|||
| @Override | |||
| public DTO getByUuid(String uuid) { | |||
| return Optional.of(uuid).map(u -> service.getByUuid(u, true)).map(this::toPseudonymizedDto).orElse(null); | |||
| return Optional.of(uuid).map(u -> { | |||
There was a problem hiding this comment.
please do this only in person facade ejb
leventegal-she
requested changes
Jan 30, 2025
| @@ -443,7 +454,8 @@ public CommitDiscardWrapperComponent<PersonEditForm> getPersonEditComponent( | |||
| editView.addCommitListener(() -> { | |||
| if (!editForm.getFieldGroup().isModified()) { | |||
| PersonDto dto = editForm.getValue(); | |||
| savePerson(dto); | |||
| savePersonWithPersonConditionChanged(dto); | |||
| // savePerson(dto); | |||
There was a problem hiding this comment.
please delete the commented line
added 2 commits
January 30, 2025 10:13
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13249 |
sergiupacurariu
deleted the
feature-13211_update_case_when_person_set_to_Dead_or_buried
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ied"
Fixes #13211