Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(client): 공연 정보 조회 무한 스크롤 해결 및 공연 개수 api 연결 #280

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

daahyunk
Copy link
Member

📌 Summary

📚 Tasks

  • 공연 정보 조회 무한 스크롤 구현 및 공연 개수도 서버 응답값 사용하게 수정하였습니다.

@daahyunk daahyunk added 👾 Fix 버그 수정 관련 다현 🎧 다현 labels Jan 24, 2025
@daahyunk daahyunk self-assigned this Jan 24, 2025
@daahyunk daahyunk requested a review from a team as a code owner January 24, 2025 18:08
@daahyunk daahyunk requested review from gwagjiug, seueooo, m2na7 and bongtta and removed request for a team January 24, 2025 18:08
@daahyunk daahyunk linked an issue Jan 24, 2025 that may be closed by this pull request
Comment on lines +22 to +23
const baseUrl = `performances/association/${artistId}`;
const url = cursor === 1 ? baseUrl : `${baseUrl}?cursor=${cursor}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 그냥 가독성 좋게 수정했어요 ☺️

@m2na7 m2na7 merged commit 17c9223 into develop Jan 24, 2025
1 check failed
@m2na7 m2na7 deleted the fix/perfo/#275 branch February 11, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
다현 🎧 다현 👾 Fix 버그 수정 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: 공연 2개만 뜨는 이슈 해결
4 participants