Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDo 완료 상태 변경 API 구현 #63

Merged
merged 3 commits into from
Jan 20, 2025
Merged

ToDo 완료 상태 변경 API 구현 #63

merged 3 commits into from
Jan 20, 2025

Conversation

chaaehyun
Copy link
Collaborator

✨ Related Issue

📝 기능 구현 명세

  • 투두 완료 상태 true -> false , false -> true 변경 구현
  • 투두 생성시 발생하는 에러 잡기

🐥 추가적인 언급 사항

@chaaehyun chaaehyun added the enhancement New feature or request label Jan 20, 2025
@chaaehyun chaaehyun self-assigned this Jan 20, 2025
@chaaehyun chaaehyun linked an issue Jan 20, 2025 that may be closed by this pull request
feat: 투두 완료 상태 변경 API #60
Closed
2 tasks
paragon0107
paragon0107 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@paragon0107 paragon0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했슘당

chaaehyun
chaaehyun commented Jan 20, 2025
View reviewed changes
src/main/java/com/official/memento/todo/domain/ToDo.java
final boolean isCompleted
){
this.isCompleted=isCompleted;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public void updateCompletion( ){
this.isCompleted!=isCompleted;
}

@chaaehyun chaaehyun merged commit bb320be into develop Jan 20, 2025
1 check passed
@chaaehyun chaaehyun deleted the update-todo-completion-status-api branch January 20, 2025 21:03
@ksarangee ksarangee mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paragon0107 paragon0107 paragon0107 approved these changes

@unanchoi unanchoi Awaiting requested review from unanchoi

@ksarangee ksarangee Awaiting requested review from ksarangee

Assignees

@chaaehyun chaaehyun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 투두 완료 상태 변경 API
2 participants
@chaaehyun @paragon0107