단일 ToDo 수정 API 구현 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
paragon0107
approved these changes
Jan 20, 2025
| @Override | ||
| public ToDo update(final ToDo toDo){ | ||
| ToDoEntity toDoEntity = toDoJpaRepository.save(ToDoEntity.withId(toDo)); | ||
| toDoEntity.update( |
There was a problem hiding this comment.
서비스에서 업데이트 되어 어댑터로 전달되었으니 추가적인 업데이트는 없어도 될 듯 합니다
There was a problem hiding this comment.
최종적으로 엔티티도 업데이트 된 값들이 저장 되어야 된다고 생각해서 엔티티 수정하는 로직을 추가했습니다!
| @Override | ||
| public ToDoTag update(final ToDoTag toDoTag) { | ||
| ToDoTagEntity toDoTagEntity = toDoTagJpaRepository.save(ToDoTagEntity.withId(toDoTag)); | ||
| toDoTagEntity.updateTag( |
There was a problem hiding this comment.
투두어댑터에서 단 리뷰내용과 동일합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항