Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#36-apple-login-api #54

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Feat/#36-apple-login-api #54

merged 8 commits into from
Jan 20, 2025

Conversation

ksarangee
Copy link
Collaborator

@ksarangee ksarangee commented Jan 18, 2025 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

  • 전체적인 소셜 로그인 API (구글,애플) 완료했고 사용자 회원가입(첫 로그인) 시 멤버 저장 로직 구현했습니다
  • TODO:
  • 사용자 회원가입 시 생성된 memberId로 tag 테이블에 기본 태그 정보 저장하는 부분을 추가 구현해야 합니다.
  • 리팩토링-> Controller에서 usecase 참조해야 합니다.

@ksarangee ksarangee self-assigned this Jan 18, 2025
@ksarangee ksarangee added DO NOT MERGE‼️ merge no no and removed DO NOT MERGE‼️ merge no no labels Jan 18, 2025
paragon0107
paragon0107 reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@paragon0107 paragon0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니닷. 제가 올린 코드들 보면서 엔티티구조나 어댑터 구조 참고해서 수정해주시면 좀 편하게 수정하실 수 있을거에요. 어려우면 이따 저녁에 같이 봐도 좋을것 같습니당

src/main/java/com/official/memento/auth/controller/AuthApiController.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/auth/infrastructure/AuthRepositoryAdapter.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/auth/infrastructure/AuthRepositoryAdapter.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/auth/infrastructure/apple/AppleAuthClientAdapter.java Show resolved Hide resolved
src/main/java/com/official/memento/auth/service/AuthResult.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/member/infrastructure/persistence/MemberAuthEntity.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/member/infrastructure/persistence/MemberEntity.java Outdated Show resolved Hide resolved
src/main/java/com/official/memento/member/infrastructure/persistence/MemberEntity.java Outdated Show resolved Hide resolved
...in/java/com/official/memento/member/infrastructure/persistence/MemberPersonalInfoEntity.java Outdated Show resolved Hide resolved
...in/java/com/official/memento/member/infrastructure/persistence/MemberPersonalInfoMapper.java Outdated Show resolved Hide resolved
@ksarangee ksarangee added the DO NOT MERGE‼️ merge no no label Jan 20, 2025
@ksarangee ksarangee removed the DO NOT MERGE‼️ merge no no label Jan 20, 2025
paragon0107
paragon0107 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@paragon0107 paragon0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생쓰용

@ksarangee ksarangee merged commit c04f767 into develop Jan 20, 2025
1 check passed
@ksarangee ksarangee deleted the feat/#36-apple-login-api branch January 21, 2025 11:32
@ksarangee ksarangee mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paragon0107 paragon0107 paragon0107 approved these changes

@chaaehyun chaaehyun Awaiting requested review from chaaehyun

@unanchoi unanchoi Awaiting requested review from unanchoi

Assignees

@ksarangee ksarangee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 애플 로그인 API
2 participants
@ksarangee @paragon0107