Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

단일 ToDo 삭제 API 구현 #51

Merged
merged 1 commit into from
Jan 18, 2025
Merged

단일 ToDo 삭제 API 구현 #51

merged 1 commit into from
Jan 18, 2025

Conversation

chaaehyun
Copy link
Collaborator

✨ Related Issue

📝 기능 구현 명세

  • 단일 ToDo Id 값 Param 으로 받아 DELETE

🐥 추가적인 언급 사항

@chaaehyun chaaehyun added the enhancement New feature or request label Jan 18, 2025
@chaaehyun chaaehyun self-assigned this Jan 18, 2025
@chaaehyun chaaehyun linked an issue Jan 18, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@unanchoi unanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!

Comment on lines +139 to +140
if (toDo.getMemberId() != memberId) {
throw new IllegalArgumentException("해당 투두를 소유하지 않음");//커스텀으로 바꿔야함
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 할 떄, TODO: 같이 달아주시면 좋습니당 ㅎㅎ

throw new IllegalArgumentException("해당 투두를 소유하지 않음");//커스텀으로 바꿔야함
}
}

private int determineOrder() {
// 순서 결정 로직 (예: 기본값은 0, 나중에 수정 가능)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 할 떄, TODO: 같이 달아주시면 좋습니당 ㅎㅎ

@chaaehyun chaaehyun merged commit 61a9f9d into develop Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: delete-single-todo-API
2 participants