[feat] #53 - 상품 상세 정보 조회 api #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
커밋 0e0c6c3는 신경쓰지 않으셔도 됩니닷 |
| public record StoreReviewDto( | ||
| Long reviewId, | ||
| String reviewerNickname, | ||
| float rating, |
| public record ProductDetailResponse( | ||
| boolean isInterested, | ||
|
|
||
| @JsonProperty("productDetail") |
There was a problem hiding this comment.
이렇게 반환 필드명 정의하는 것 좋네요~
| @@ -16,18 +16,17 @@ | |||
|
|
|||
| @Component | |||
| @RequiredArgsConstructor | |||
| @Transactional(readOnly = true) | |||
There was a problem hiding this comment.
retriever에 붙이는 건 좋지만 다른 클래스는 웬만하면 위에 붙이지 않도록 합시당
|
책임 분리도 잘 돼있고 잘 구현해내신 것 같습니다!! 굿입니다👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
각 큰 필드마다 dto를 만들어서 합치는 식으로 구현하였습니다.
상품 등록자 관련 review는 개수제한을 두지 않고 모두 가져옵니다.
리뷰가 없으면 빈 리스트를 가져옵니다.
판매자의 상품 중 trade status가 TRADE_COMPLETED인 것으로 transaction count를 하였습니다.
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢