[feat] #78 - 좋아요, 좋아요 해제 기능 구현 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/napzak/domain/product/core/ProductRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/interest/core/InterestSaver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/interest/core/InterestSaver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/interest/core/InterestRemover.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/interest/core/InterestProductFacade.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/interest/api/controller/InterestController.java
Outdated
Show resolved
Hide resolved
|
각 계층의 역할분리 관련 코멘트 달았습니다! 그렇게 무거운 pr은 아니라서 금방 코멘트 반영 가능하실 것 같네요ㅎㅎ 반영 부탁드립니다 |
Comment on lines
14
to
17
| @Transactional | ||
| public void decrementInterestCount(Long productId) { | ||
| productRepository.decrementInterestCount(productId); | ||
| } |
There was a problem hiding this comment.
decrementInterestCount는 product의 interestCount만 바꾸는 메소드이므로 ProductRemover보다는 ProductUpdater에 있는 게 적절할 것 같습니다!
Comment on lines
9
to
10
| import com.napzak.domain.product.api.exception.ProductErrorCode; | ||
| import com.napzak.domain.product.core.ProductRetriever; |
There was a problem hiding this comment.
ProductRetriever를 호출해야하는 건 facade로 불러옵시다!
그리고 ErrorCode는 InterestErrorCode 만들어서 거기안에 코드 정의하면 좋을 것 같습니다
Comment on lines
35
to
37
| if (!productRetriever.existsById(productId)) { //존재하지 않는 product | ||
| throw new NapzakException(ProductErrorCode.PRODUCT_NOT_FOUND); | ||
| } |
There was a problem hiding this comment.
밑에서 interest의 존재 여부를 확인하기 때문에 product의 존재 여부 검증은 필요치 않을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
좋아요를 누른 상태에서 다시 요청을 보낼 수 없도록 하였습니다.
좋아요를 누르지 않은 상태에서 좋아요 해제를 할 수 없도록 하였습니다.
좋아요를 누르면 product의 interestCount를 증가시킵니다.
좋아요를 해제하면 감소시킵니다.
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢