[feat] #74 - 마이페이지, 상점 정보 조회 api 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/napzak/domain/store/api/StoreGenreFacade.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/store/api/controller/StoreController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/store/api/controller/StoreController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/store/api/controller/StoreController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/global/common/config/SecurityConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/store/api/service/StoreService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/napzak/domain/store/api/service/StoreService.java
Outdated
Show resolved
Hide resolved
|
다른 pr과 겹치는 코멘트들이 많네요 반영 부탁드립니다~ |
…er storeId -> currentStoreId)
| @CurrentMember final Long currentStoreId | ||
| ) { | ||
|
|
||
| List<GenrePreference> genreList = storeService.getGenrePreferenceList(OnwerId); |
There was a problem hiding this comment.
GenrePreference는 storeGenreFacade를 통해 조회해오면 될 것 같습니다!
There was a problem hiding this comment.
genrePreference가 store 도메인 안에 있어서 storeService로 호출하였습니다!
| String storeDescription, | ||
| String storePhoto, | ||
| String storeCover, | ||
| List<GenrePreferenceResponse> genrePreferences |
There was a problem hiding this comment.
GenrePreferenceResponse -> GenrePreferenceDto
Response는 controller에서 최종적으로 반환하는 dto에만 붙이고, response 내에서만 사용되는 건 뒤에 Dto라고 붙여서 구분해줄게요!
Comment on lines
8
to
9
| import org.springframework.stereotype.Repository; | ||
|
|
There was a problem hiding this comment.
안 사용되는 import 문 같은데 맞다면 삭제해주세요!
| @@ -1,6 +1,7 @@ | |||
| package com.napzak.domain.store.core; | |||
|
|
|||
| import java.util.List; | |||
| import java.util.stream.Collectors; | |||
There was a problem hiding this comment.
안 사용되는 import 문 같은데 맞다면 삭제해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
마이페이지 정보를 조회합니다.
상점 id를 받아 특정 상점 정보를 조회합니다.
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢