[feat] #135 - AOP 적용 및 api별 쿼리 개수 추적 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hyerinhwang-sailin
temporarily deployed
to
dev
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
api 요청을 쉽게 파악하고, 성능 파악을 위해 요청당 발생한 쿼리 개수와 소요시간을 로깅할 수 있도록 spring-aop를 적용했습니다.
참고한 자료는 아래와 같습니다.
https://velog.io/@ohzzi/API%EC%9D%98-%EC%BF%BC%EB%A6%AC-%EA%B0%9C%EC%88%98-%EC%84%B8%EA%B8%B0-1-%ED%95%98%EC%9D%B4%EB%B2%84%EB%84%A4%EC%9D%B4%ED%8A%B8%EB%A5%BC-%EC%9D%B4%EC%9A%A9%ED%95%9C-%EC%B9%B4%EC%9A%B4%ED%8C%85
https://velog.io/@ohzzi/API%EC%9D%98-%EC%BF%BC%EB%A6%AC-%EA%B0%9C%EC%88%98-%EC%84%B8%EA%B8%B0-2-JDBC-Spring-AOP-Dynamic-Proxy%EB%A5%BC-%ED%99%9C%EC%9A%A9%ED%95%9C-%EC%B9%B4%EC%9A%B4%ED%8C%85
https://tecoble.techcourse.co.kr/post/2021-06-25-aop-transaction/
https://www.jaenung.net/tree/937?srsltid=AfmBOoo9p6gltS_Re13G4YnjafB71-Q2dPviqlfZc-fKsLJFSJ3HAuS2
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢
성능 모니터링 관련해서 aop 보완할 수 있을 것 같습니다!
그리고 우선 예상 보다 쿼리 개수가 많이 나오는 api들이 있어서 쿼리 개수 줄이도록 리팩토링 우선 진행해보면 좋을 듯합니다~