[feat] #113 - 상품상세정보 조회 api 구해요 상품 이슈 해결 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hyerinhwang-sailin
temporarily deployed
to
dev
GitHub Actions
Inactive
hyerinhwang-sailin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
상품상세정보 조회 시 구해요 상품은 productCondition가 null인데 이를 .toString을 시도하면서 에러가 발생했습니다.
그래서 dto 생성 시 productCondition null 체크 추가하여 null일 경우 string화하지 않고 null을 반환하도록 했습니다.
또한
@JsonInclude(JsonInclude.Include.NON_NULL)어노테이션을 통해 null일 경우 dto에서 제외하도록 했습니다.Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢