Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes keep getting deleted #13

Closed
JaneJeon opened this issue Aug 14, 2019 · 3 comments · Fixed by #16
Closed

Themes keep getting deleted #13

JaneJeon opened this issue Aug 14, 2019 · 3 comments · Fixed by #16
Assignees

Comments

@JaneJeon
Copy link
Collaborator

JaneJeon commented Aug 14, 2019

Hi, I host this on free plan heroku, which means it goes to sleep.

I had a blog working with this before yesterday's updates, but now that I updated the blog, Heroku seems to delete ALL of Ghost's themes every time it goes to sleep.

The only thing that changed was the code, so I'm guessing it's probably this commit - 3e40b8d - that broke it.

Oh, and I should mention - one of the blog uses the default casper theme (with newest version of ghost-on-heroku), and that one doesn't break even on sleep, however the other one uses the London theme (which I upload via zip to install) and when I do that, it works... until it sleeps and deletes the theme (in fact, when it wakes up it says "no theme installed!")

edit: on further investigation, it seems to be an issue with heroku and symlinks? https://stackoverflow.com/questions/10462787/how-do-i-use-npm-link-with-heroku because when I run heroku run ls content/themes, it shows the 5 "installed" themes, but when I boot it up none of the themes are there!

update: npm link didn't help, either...

@JaneJeon
Copy link
Collaborator Author

JaneJeon commented Aug 14, 2019

Update update: I realize that this is similar to #9, but my problem is that I don't even see the "default" themes that should be installed via node_modules - casper, london, attilla, etc! They're all gone after a sleep... 😱

at this point I'm pretty sure it's a problem with symlinks on Heroku (see link above) and the commit 8742556

@JaneJeon
Copy link
Collaborator Author

From what I can tell, the only way to get this to work on heroku is to actually include node_modules and not gitignore it...

It feels so, so, so dirty, but it seems to be the only way @SNathJr

@SNathJr
Copy link
Owner

SNathJr commented Aug 14, 2019

@JaneJeon sounds like a fix, though it will be a dirty one. Also, when building from source the Heroku Dyno should generate this folder by default. Let me investigate it further. Will try to push some update later today.

Another dirty fix would be to add themes manually to the content/themes folder.

Thanks!

@JaneJeon JaneJeon self-assigned this May 2, 2020
nickolson referenced this issue in nickolson/ghost-on-heroku Apr 20, 2022
Update Lyra dependency in package.json - change the branch from master to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants