-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing preSN registry models #296
Conversation
…the model classes
…chiveModel to the loaders
I’ve finished looking through the code-level changes; they all look good to me. Thanks a lot, @Sheshuk! Before I accept and merge this PR, I’d like to try some usage examples. I noticed that the demo notebooks (e.g. https://github.com/SNEWS2/snewpy-models-presn/blob/master/models/Patton_2017/Patton.ipynb) still use the old (filename-based) initalisation, which doesn’t work with this PR. Have you started updating those already, or should I go ahead, update them as I try them out and make a PR on the snewpy-models-presn repo? |
Thanks @JostMigenda! I will update these examples, they're rather old in general. |
Also fixes a bug where a scalar value for E (e.g. 10*u.MeV) would not work, and a length-1 array (e.g. [10]*u.MeV) was required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
Closes #243
Closes #290
test_02_models.py
)base
to theloaders
module.LocalFileLoader
class for checking if the requested file existsRegistryFileLoader
to download the requested file from the_model_downloader
Todo: