refactor hop-pub #32
Open
refactor hop-pub #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made a class for some hop-pub methods
added detectors with ID and locations. Added a notebook
moved some of the functions in hop_pub to snews_utils
simple logging test
added a new json-format saving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a class for some hop-pub methods
Description
Refactored the hop_pub.py script. Some of the methods are implemented in classes.
There is also the Test.ipynb notebook showing the application of the methods of the class.
Checklist
/tests, ensuring sufficient code coverage.make testruns without errors.make lintdoesn't give any warnings.make formatdoesn't give any code formatting suggestions.make docruns without errors and generated docs render correctly.NOTE: If this PR relates to a release, open and reference an issue with the Release checklist template.