Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a couple of hints to snews-local-tutorial.md #27

Open
wants to merge 1 commit into
base: demo/tutorial
Choose a base branch
from

Conversation

tsengj10
Copy link

Description

Added a hint in Step 3 that the actual command lines follow, also a command to stop the docker containers started with the run-containers.sh script

(Do we need the checklist for updating documentation?)

Checklist

  • All new functions and classes are documented and adhere to Google doc style (3.8.3-3.8.6 of this document)
  • Add/update sphinx documentation with any relevant changes.
  • Add/update pytest-style tests in /tests, ensuring sufficient code coverage.
  • make test runs without errors.
  • make lint doesn't give any warnings.
  • make format doesn't give any code formatting suggestions.
  • make doc runs without errors and generated docs render correctly.
  • Check that CI pipeline run on this PR passes all stages.
  • Review signoff by at least one developer.

NOTE: If this PR relates to a release, open and reference an issue with the Release checklist template.

Added a hint in Step 3 that the actual command lines follow, also a command to stop the docker containers started with the run-containers.sh script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant