Add EMEWS.data submodule with PREM files
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the binary extension doesn’t “shadow” EMEWS submodules, like `EMEWS.data`. Uses top-level __init__.py to ensure functionality is still available by importing EMEWS
Raw cpp/h files are unnecessary in compiled wheels. Exclude them to reduce wheel size by ~30%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3, ensuring users automatically have the PREM files available after installing EMEWS.
Implementation detail
I’ve moved the code for the binary extension to an
EMEWS._extsubmodule; since leaving it as the top-levelEMEWSmodule would “shadow” submodules and make it impossible to import e.g.EMEWS.data.To ensure users don’t need to worry about this implementation detail, I have imported all functionality from the binary extension in the top level
EMEWS/__init__.py, so usage remains unchanged.Procedural detail
This PR builds on #4; I’ve submitted them as separate PRs for clarity. Accordingly, the diff for this PR shows a comparison with the
JostMigenda/modernBuildbranch currently, not with themainbranch.(When merging these two PRs, we should be a little careful to avoid confusion.)