Build EMEWS in GitHub Actions #2
Conversation
* remove hard-coded paths from setup.py * remove unused distutils import in setup.py (Note that distutils has been removed in Python 3.12) * skip Ubuntu and Windows for now
Both were removed in C++17, so cause errors when compiling with the latest clang version. They can usually just be deleted, see e.g. https://stackoverflow.com/questions/63577103/what-is-an-equivalent-replacement-for-stdunary-function-in-c17 https://devblogs.microsoft.com/cppblog/c17-feature-removals-and-deprecations/#:~:text=if%20you%20have%20classes%20deriving,eliminate%20the%20inheritance
gamma is a non-standard extension in the GNU libc, see https://www.gnu.org/software/libc/manual/html_node/Special-Functions.html#index-gamma And being non-standard, it may give different results on different systems, see https://stackoverflow.com/questions/18116376/what-is-the-definition-for-gammadouble-x-and-why-is-it-different-on-two-gcc-ve 😱
JostMigenda
force-pushed
the
JostMigenda/buildWorkflow
branch
from
20f18a3 to
7170bc3
Compare
|
I had to make fixes to the There’s still one issue in the output of the example script; I’ll check next week whether that actually impacts the output files. Full script outputSo far, I’ve focussed on getting it to build on macOS; and the workflow is skipping Linux and Windows. @jpkneller and @Sheshuk, you said you’d managed to compile EMEWS on those systems? Could you please add the OS-specific instructions to the workflow? Ideally, you would only need to modify a single install step per OS, where you
… and everything else should remain unchanged. In practice, I suspect it won’t go quite as smoothly, so it’s probably best if you submit that as separate PRs (on top of this branch here) and then I can figure out how to merge everything. |
|
I fixed the bug that was cause of the exception. I also took the opportunity to fix some minor issues when the output is switched on. |
To be ready for release, we should make sure we are able to build EMEWS reproducibly in GitHub Actions. To achieve that, we need to remove hard-coded paths from the
setup.py.Getting this right across different operating systems and with different Python versions will require several iterations. This initial commit is a very early exploratory draft.