Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail recursive key parsing #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tail recursive key parsing #79

wants to merge 3 commits into from

Conversation

ygrek
Copy link
Member

@ygrek ygrek commented Jun 24, 2020

Continuing the work in #78
Now it is possible to import the following key ([email protected]) with stack lowered to 1MB (ulimit -s 1024) :

1 selfsigs, 5 uids (101025 packets), 1 subkeys (273 packets)

TODO:

  • extract the anomaly key and make a test case
  • measure speed

@ygrek ygrek self-assigned this Jun 24, 2020
@wiml
Copy link
Contributor

wiml commented Jun 25, 2020

I wonder if it would make sense to use a delayed/lazy sequence for some of this (the Seq module in stdlib)?

@ygrek
Copy link
Member Author

ygrek commented Jun 29, 2020

my only concern is List.rev on signatures, but i don't expect it to be costly on average. I don't want to raise minimum ocaml version or add more dependencies until making a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants