-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drv8825 Demo #11
Open
MichaelYKersey
wants to merge
33
commits into
SJSURoboticsTeam:main
Choose a base branch
from
MichaelYKersey:drv8825
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Drv8825 Demo #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-systems-2024 into science-update merge split work for updating demos
…ms-2024 into drv8825
kammce
requested changes
Sep 1, 2024
drivers/CMakeLists.txt
Outdated
@@ -33,6 +34,7 @@ SOURCES | |||
src/scd40.cpp | |||
src/soil_sensor_sht21.cpp | |||
src/sk9822.cpp | |||
src/drv8825.cpp | |||
|
|||
PACKAGES | |||
# libhal-__device__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# libhal-__device__ |
Delete this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment has been updated to clarify the template. look over it to see if it is clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drv8825 fix and drv8825 demo. Tested demo with 17N19S1684MB4-200RS. The motor stalls every so often, I'm unsure why. The positional stuff is untested but may inherently be unnecessary and inaccurate. I can remove those features if needed.