Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker build files #655

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Improve docker build files #655

merged 1 commit into from
Jan 12, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 30, 2023 •
edited
Loading

  • Update alpine to 3.19
  • Build using docker build, without additional commands
  • Make the result runnable

@orgads orgads mentioned this pull request Aug 30, 2023
Merged
@orgads orgads mentioned this pull request Aug 30, 2023
Closed
@lemenkov
Copy link
Member

Please rebase it on top of current master. I don't think #656 is going to be merged since it cointains 3 different changes squashed.

@orgads
Improve docker build files
c086db3 
* Update alpine to 3.19
* Build using docker build, without additional commands
* Make the result runnable
@orgads
Copy link
Contributor Author

orgads commented Jan 12, 2024

Rebased

@lemenkov
Copy link
Member

LGTM

@lemenkov lemenkov merged commit 0225983 into SIPp:master Jan 12, 2024
7 checks passed
@orgads orgads deleted the real-docker branch January 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @lemenkov