Pass the currentPosition of the item on press event along with the item data. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2019 19:09
…em data. This is very useful when i.e. you need to render overlay view right on top of the pressed item. Introducing dragEnabled property (true by default) to block drag feature.
SHISME
reviewed
Jun 26, 2019
| @@ -20,14 +20,15 @@ interface IBaseItemType { | |||
| key:string; | |||
| } | |||
|
|
|||
| export interface IDraggableGridProps<DataType extends IBaseItemType>{ | |||
| export interface IDraggableGridProps<DataType extends IBaseItemType> { | |||
| dragEnabled:boolean; | |||
There was a problem hiding this comment.
is this should be dragEnabled?:boolean;?
There was a problem hiding this comment.
We can name it dragDisabled and set default value to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful when for example you need to render an overlay view right on top of the pressed item.
Introducing dragEnabled property (true by default) to block drag feature.