-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated obsoleted functions #310
Updated obsoleted functions #310
Conversation
Your solution breaks compatibility with ImGui 1.89. What newer version of ImGui to you propose that ImGui-SFML 3 use? |
It seems that the earliest that supports this is 1.91.1, so I would say that one, although I would consider using the latest (1.91.6), which is the recommended way to go. |
How do you acquire ImGui for use with ImGui-SFML? A local git clone? A package manager? CMake FetchContent? |
Local git clone. I guess I should also update the CI and the CMake file |
How does ImGui-SFML stand to benefit from using a newer version of ImGui? Are there better features or anything else we could use? |
This is the recommended way to go according to the developer: https://github.com/ocornut/imgui/blob/master/docs/FAQ.md#q-which-version-should-i-get. |
I think I'm cool with this. We still haven't raised the ImGui requirement for ImGui-SFML 3 yet but I know that needs to happen at some point. This seems like a reasonable choice. Not necessarily sure I want to pick the latest ImGui release so 1.91.1 sounds good for now. |
The members
ImGuiIO::SetClipboardTextFn
andImGuiIO::GetClipboardTextFn
have been obsoleted. This pull request uses the new members inImGuiPlatformIO
.