Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated obsoleted functions #310

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

fgallegosalido
Copy link
Contributor

The members ImGuiIO::SetClipboardTextFn and ImGuiIO::GetClipboardTextFn have been obsoleted. This pull request uses the new members in ImGuiPlatformIO.

@ChrisThrasher
Copy link
Member

Your solution breaks compatibility with ImGui 1.89. What newer version of ImGui to you propose that ImGui-SFML 3 use?

@fgallegosalido
Copy link
Contributor Author

It seems that the earliest that supports this is 1.91.1, so I would say that one, although I would consider using the latest (1.91.6), which is the recommended way to go.

@ChrisThrasher
Copy link
Member

How do you acquire ImGui for use with ImGui-SFML? A local git clone? A package manager? CMake FetchContent?

@fgallegosalido
Copy link
Contributor Author

fgallegosalido commented Dec 23, 2024

Local git clone. I guess I should also update the CI and the CMake file

@ChrisThrasher
Copy link
Member

ChrisThrasher commented Dec 23, 2024

How does ImGui-SFML stand to benefit from using a newer version of ImGui? Are there better features or anything else we could use?

@fgallegosalido
Copy link
Contributor Author

fgallegosalido commented Dec 23, 2024

This is the recommended way to go according to the developer: https://github.com/ocornut/imgui/blob/master/docs/FAQ.md#q-which-version-should-i-get.

@ChrisThrasher
Copy link
Member

It seems that the earliest that supports this is 1.91.1, so I would say that one

I think I'm cool with this. We still haven't raised the ImGui requirement for ImGui-SFML 3 yet but I know that needs to happen at some point. This seems like a reasonable choice. Not necessarily sure I want to pick the latest ImGui release so 1.91.1 sounds good for now.

@ChrisThrasher ChrisThrasher merged commit a3f9a17 into SFML:master Dec 23, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants