Error during upsert on identical DeveloperName for RecordType of same sObject #3702
+210
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the same SObject type
aditya-balachander
requested review from
davidmreed,
jkasturi-sf and
lakshmi2506
lakshmi2506
reviewed
Nov 13, 2023
Added test for upsert to check same DeveloperName but different IsPersonType on the RecordType
Fixed an error where if org has no person account enabled then IsPersonType column does not exist
jkasturi-sf
previously approved these changes
Dec 26, 2023
jkasturi-sf
approved these changes
Dec 28, 2023
jstvz
pushed a commit
that referenced
this pull request
Feb 1, 2024
Fix for [issue](https://trailhead.salesforce.com/trailblazer-community/feed/0D54V00007XIPZMSA5) related to your recent PR ([3702](#3702)). **Error Message:** `AttributeError: is_person_type` **Issue Reason:** During load, the tasks expects the column `is+person_type` to be present in the record type table `rt_mapping_table`. This column is present for sql files which do extract after the new release of CumulusCI (v3.84.0) but will not be present for existing sql files. **Fix:** Previously the `outerjoins_to_add` function of the `AddRecordTypesToQuery` class checks if the combination of `is_person_type` and `developer_name` is unique. Now, if the `rt_mapping_table` does not have the `is_person_type` table, the task ignores the condition to check for record types based on `is_person_type` and only checks for `developer_name` (as it was previous to this PR [3702](#3702)) --------- Co-authored-by: Jaipal Reddy Kasturi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-11466074
Fixed a bug during upsert (load) of records where if the sObject had two record types with the same
DeveloperNamebut differentIsPersonType, duplicate records were being generated for load and as a result, error was thrown.Example: For the sObject
Account, the record typePersonAccountshasDeveloperName = PersonAccountsandIsPersonType = True. I could also create another recordType such thatDeveloperName = PersonAccountsbut theIsPersonType = False. In such cases, say I was trying to upsert 1 record (any update_key) with thisPersonAccounts(one of the two), 2 records would try to get inserted and would throw a duplicate row error.