Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Imperva module connector #912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

StephKll3c
Copy link
Contributor

No description provided.

@PierrickV
Copy link
Contributor

you might need to bump the version ?

Copy link

github-actions bot commented Apr 3, 2024

Test Results

19 tests   - 21   19 ✅  - 20   0s ⏱️ -11s
 1 suites  -  1    0 💤  -  1 
 1 files    -  1    0 ❌ ± 0 

Results for commit 9c84d01. ± Comparison against base commit 6424ef3.

This pull request removes 40 and adds 19 tests. Note that renamed tests count towards both.
tests.client.test_auth ‑ test_api_client_check_validity_before_refresh
tests.client.test_auth ‑ test_authentication_failure_connection_error
tests.client.test_auth ‑ test_authentication_failure_invalid_credentials
tests.client.test_auth ‑ test_authentication_failure_invalid_json
tests.client.test_auth ‑ test_authentication_failure_no_json
tests.client.test_auth ‑ test_authentication_failure_unsupported_exception
tests.client.test_auth ‑ test_authentication_success
tests.client.test_auth ‑ test_get_access_token_trigger_authentication
tests.client.test_auth ‑ test_get_access_token_triggers_critical_log_on_auth_error
tests.test_comment_incident ‑ test_run_to_comment_an_incident
…
tests.test_fetch_log ‑ test_decrypt_file_key_exception_while_decrypting
tests.test_fetch_log ‑ test_decrypt_file_key_missing_in_config
tests.test_fetch_log ‑ test_decrypt_success
tests.test_fetch_log ‑ test_fetch_log
tests.test_fetch_log ‑ test_fetch_logs_10_retries_index_reset_retries
tests.test_fetch_log ‑ test_fetch_logs_10_retries_index_skipping_file
tests.test_fetch_log ‑ test_fetch_logs_10_retries_index_too_old
tests.test_fetch_log ‑ test_validate_checksum
tests.test_file_downloader ‑ test_file_downloader_200_with_proxy
tests.test_file_downloader ‑ test_file_downloader_401
…

♻️ This comment has been updated with latest results.

@StephKll3c
Copy link
Contributor Author

StephKll3c commented Apr 3, 2024

you might need to bump the version ?

Yes ! Thx :)

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (7cd5fb5) to head (9c84d01).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   89.63%   89.79%   +0.15%     
==========================================
  Files         318      318              
  Lines       11726    11702      -24     
  Branches      839      839              
==========================================
- Hits        10511    10508       -3     
+ Misses       1127     1106      -21     
  Partials       88       88              
Flag Coverage Δ
Imperva 81.84% <ø> (+5.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

run black

Update version

update sdk version
@StephKll3c StephKll3c force-pushed the sc-fix-module-connector branch from f8ce7b2 to 9c84d01 Compare April 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants