Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: salesforce additional limits #778

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vg-svitla
Copy link
Collaborator

No description provided.

@vg-svitla vg-svitla requested a review from squioc February 1, 2024 12:26
Copy link

github-actions bot commented Feb 1, 2024

Test Results

24 tests  +20   24 ✅ +20   2s ⏱️ +2s
 1 suites ± 0    0 💤 ± 0 
 1 files   ± 0    0 ❌ ± 0 

Results for commit 581bb8f. ± Comparison against base commit 107ea73.

This pull request removes 4 and adds 24 tests. Note that renamed tests count towards both.
tests.test_fastly_waf ‑ test_fetch_events
tests.test_fastly_waf ‑ test_fetch_events_with_pagination
tests.test_fastly_waf ‑ test_long_next_batch_should_not_sleep
tests.test_fastly_waf ‑ test_next_batch_sleep_until_next_round
tests.client.schemas.test_log_file ‑ test_event_log_file
tests.client.schemas.test_log_file ‑ test_event_log_file_response
tests.client.schemas.test_token ‑ test_token_is_valid
tests.client.test_http_client ‑ test_salesforce_http_client_error_response_with_non_200_status
tests.client.test_http_client ‑ test_salesforce_http_client_get_log_file_content
tests.client.test_http_client ‑ test_salesforce_http_client_get_log_file_content_2
tests.client.test_http_client ‑ test_salesforce_http_client_get_log_files
tests.client.test_http_client ‑ test_salesforce_http_client_handle_error_response
tests.client.test_http_client ‑ test_salesforce_http_client_log_files_query
tests.client.test_http_client ‑ test_salesforce_http_client_log_files_query_1
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (107ea73) 90.17% compared to head (581bb8f) 90.11%.

Files Patch % Lines
Salesforce/salesforce/__init__.py 80.95% 3 Missing and 1 partial ⚠️
Salesforce/client/http_client.py 97.14% 2 Missing ⚠️
Salesforce/tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   90.17%   90.11%   -0.06%     
==========================================
  Files         303      295       -8     
  Lines       11516    11435      -81     
  Branches      816      808       -8     
==========================================
- Hits        10384    10305      -79     
  Misses       1051     1051              
+ Partials       81       79       -2     
Flag Coverage Δ
Salesforce 95.99% <95.67%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squioc squioc force-pushed the fix/vg_salesforce_additional_limiters branch from 2846fa0 to 581bb8f Compare February 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants