Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for file output #1272

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

add support for file output #1272

wants to merge 17 commits into from

Conversation

rombernier
Copy link
Contributor

@rombernier rombernier commented Feb 4, 2025 •
edited
Loading

context

@rombernier
Copy link
Contributor Author

Hello @squioc, if you can check the mypy error ? Thanks

squioc
squioc requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.
Can you add a test to validate the change? Thank you

MicrosoftActiveDirectory/microsoft_ad/search.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? Like this one

@rombernier
Copy link
Contributor Author

Hello @squioc, le test avec le fichier ne passe pas, l'init/le mock du datapath est en erreur: Module.init() got an unexpected keyword argument 'data_path'. Est-ce que tu pourrais me débloquer. Je trouve pas la diff avec les autres exemples comme l'action MISP

squioc
squioc requested changes Feb 11, 2025
View reviewed changes
MicrosoftActiveDirectory/tests/test_search.py Outdated Show resolved Hide resolved
MicrosoftActiveDirectory/tests/test_search.py Outdated Show resolved Hide resolved
MicrosoftActiveDirectory/tests/test_search.py Outdated Show resolved Hide resolved
squioc
squioc requested changes Feb 11, 2025
View reviewed changes
MicrosoftActiveDirectory/tests/conftest.py Show resolved Hide resolved
MicrosoftActiveDirectory/tests/conftest.py Outdated Show resolved Hide resolved
MicrosoftActiveDirectory/microsoft_ad/search.py Outdated Show resolved Hide resolved
MicrosoftActiveDirectory/tests/test_search.py Outdated Show resolved Hide resolved
@rombernier
Copy link
Contributor Author

Hello @squioc, can you check the issue with mypy ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squioc squioc squioc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rombernier @squioc