Add Reverse Electrodialysis model #78
Conversation
There was a problem hiding this comment.
I haven't reviewed the REDstack.py file but I suppose that many of the comments for the other python file apply, so let's cover those for both files first, and then I will complete the review.
In general, there are a few typos, many "magic number" (numbers in the constraints that should be defined as parameters) and several comments that should be either removed or integrated as notes or documentation of the Pyomo model elements.
Another big one is that I want you to replace the Excel file with CSV files and sort out the imports
| wnd_dir = os.path.dirname(os.path.realpath(__file__)) | ||
|
|
||
|
|
||
| # The data.xlsx file contains the financial and stack parameters, and properties of the high and low salinity feed streams. |
There was a problem hiding this comment.
Can you import this from CSV files instead of Excel? These are harder to read in Unix.
There was a problem hiding this comment.
I tried to load data from CSVs but ran into an AttributeError, so I need to work on a solution.
Commented out in commit e2259c6
…rrect typos, remove comments, and update documentation
…ation, and update constant definitions
… correlation, operational and maintenance cost, stack capital cost, civil and infrastructure cost
… and feed data in REDstack.py
Introduce a new GDP model for the optimal design of the reverse electrodialysis process, including relevant data and documentation.