Skip to content

Commit

Permalink
tmp: address pr reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
luca-schlecker committed Jan 16, 2025
1 parent 24e1ce0 commit bf5445f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 5 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,9 @@ automatically after every push to `main` and `develop` as well as after a
version tag has been set. The generated documentation is packaged into a
docker container running [nginx](https://nginx.org/) and is served on the
internal port `80`.

The documentation can be built locally using docker:
```bash
docker build . -t snowballr-api
docker run -it -p 8080:80 snowballr-api:latest
```
2 changes: 1 addition & 1 deletion proto/authentication.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ message PasswordChangeRequest {
string new_password = 2;
}

message EMailChangeRequest {
message EmailChangeRequest {
string new_email = 1;
}
5 changes: 3 additions & 2 deletions proto/main.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ service SnowballR {

rpc Register (RegisterRequest) returns (LoginSecret);
rpc Login (LoginRequest) returns (LoginSecret);
rpc Logout (Nothing) returns (Nothing);
rpc IsAuthenticated (Nothing) returns (BoolValue);
rpc RenewSession (RenewRequest) returns (LoginSecret);
rpc RequestPasswordReset (RequestPasswordResetRequest) returns (Nothing);
rpc ResetPassword (PasswordResetRequest) returns (Nothing);
rpc ChangePassword (PasswordChangeRequest) returns (Nothing);
rpc ChangeEMail (EMailChangeRequest) returns (Nothing);
rpc ChangeEmail (EmailChangeRequest) returns (Nothing);


rpc GetAllUsers (Nothing) returns (User.List);
// The currently logged in user of this session.
rpc GetCurrentUser (Nothing) returns (User);
rpc GetUserById (Id) returns (User);
rpc GetUserByEMail (Id) returns (User);
rpc GetUserByEmail (Id) returns (User);
rpc UpdateUser (User.Update) returns (User);
rpc SoftDeleteUser (Id) returns (Nothing);
rpc SoftUndeleteUser (Id) returns (Nothing);
Expand Down
3 changes: 2 additions & 1 deletion proto/project.proto
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ message Project {
string name = 2;
ProjectStatus status = 3;
uint64 current_stage = 4;
Settings settings = 5;
uint64 max_stage = 5;
Settings settings = 6;

message List {
repeated Project projects = 1;
Expand Down
2 changes: 1 addition & 1 deletion proto/user_settings.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import "project.proto";
message UserSettings {
bool show_hotkeys = 1;
bool review_mode = 2;
Project.Settings project_settings = 3;
Project.Settings default_project_settings = 3;
Criterion.List default_criteria = 4;

message Update {
Expand Down

0 comments on commit bf5445f

Please sign in to comment.