Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the assert then when using Data/Name in AnimatedImage #309

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix the assert then when using Data/Name in AnimatedImage #309

merged 1 commit into from
Mar 27, 2024

Conversation

dreampiggy
Copy link
Collaborator

Should match the logic as URL, the updateView is called multiple times, so it should not hit assert

This is bug introduced in #304

@dreampiggy
Fix the assert then using Data/Name in AnimatedImage
b550096 
Should match the logic as URL, allows to set
@dreampiggy dreampiggy added the bug Something isn't working label Mar 27, 2024
@dreampiggy dreampiggy added this to the 3.0.2 milestone Mar 27, 2024
@dreampiggy dreampiggy merged commit c79754f into master Mar 27, 2024
6 checks passed
@dreampiggy dreampiggy changed the title Fix the assert then using Data/Name in AnimatedImage Fix the assert then when using Data/Name in AnimatedImage Mar 27, 2024
@dreampiggy dreampiggy deleted the bugfix/animatedimage branch March 30, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy