Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom styling #2

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Enable custom styling #2

wants to merge 6 commits into from

Conversation

iamfrank
Copy link

Enables the user to set colours individually for every type of vector on map.

Possible improvements:

  • Should probably be added as a separate tab
  • Not all vector layer names make intuitive sense. Maybe create logical groupings that can be coloured in one go.

@iamfrank iamfrank requested a review from Gebuz June 10, 2024 07:04
@Gebuz
Copy link
Contributor

Gebuz commented Jun 10, 2024

I've made a few updates to the CSS.

I'm not sure how switching between the styles should interact with the custom styling. Here are a few solutions I've considered:

  1. Reset all the colors to the new style when switching between styles. The downside here is that any colors the user has manually set is wiped when switching. That could be solved by saving the state for each style.
  2. Create a new layer and only allow the user to edit that one. The problem here is that the user can't select their starting point. Maybe this could be a good solution if it is added to it's own separate tab combined with the ability to copy all styles from any of the styles on the style selector tab.

Other things to keep in mind:

@iamfrank
Copy link
Author

Those are relevant improvements to consider. Let's hold back this PR until they are resolved.

@iamfrank iamfrank marked this pull request as draft October 29, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants