-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First update to many of the base configuration files to better match … #8
base: main
Are you sure you want to change the base?
Conversation
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove Sonja here, I think
@@ -57,7 +56,8 @@ help you decide which tool to use for packaging. | |||
- The documentation is set up with the ReadTheDocs Sphinx theme. | |||
- Check out its [configuration options](https://sphinx-rtd-theme.readthedocs.io/en/latest/). | |||
- [AutoAPI](https://sphinx-autoapi.readthedocs.io/) is used to generate documentation for the package Python objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to use sphinx or mkdocs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sphinx is used by the template. I don't really know the differences, so I don't have a preference here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. Had a few minor comments/questions.
Resolves issue #7
I adjusted a number of things in the base config (mostly in the base directory) to better fit the DGL-PTM implementations to be added.
Installed the package following README.dev.md instructions successfully
Running pytest works as intended.