Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First update to many of the base configuration files to better match … #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vanlankveldthijs
Copy link

Resolves issue #7

I adjusted a number of things in the base config (mostly in the base directory) to better fit the DGL-PTM implementations to be added.

Installed the package following README.dev.md instructions successfully
Running pytest works as intended.

pyproject.toml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove Sonja here, I think

@@ -57,7 +56,8 @@ help you decide which tool to use for packaging.
- The documentation is set up with the ReadTheDocs Sphinx theme.
- Check out its [configuration options](https://sphinx-rtd-theme.readthedocs.io/en/latest/).
- [AutoAPI](https://sphinx-autoapi.readthedocs.io/) is used to generate documentation for the package Python objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use sphinx or mkdocs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sphinx is used by the template. I don't really know the differences, so I don't have a preference here...

Copy link
Member

@meiertgrootes meiertgrootes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Had a few minor comments/questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants