some easy lgtm fixes

SCS-Labs · Sep 11, 2020 · d844289 · d844289
1 parent 78e3a0a
commit d844289
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/viewer/pcap.js b/viewer/pcap.js
@@ -914,7 +914,6 @@ exports.reassemble_tcp = function (packets, numPackets, skey, cb) {
       packets2.push(packets[i]);
     }
     packets = packets2;
-    packets2 = [];
 
     if (packets.length === 0) {
       return cb(null, packets);

diff --git a/viewer/viewer.js b/viewer/viewer.js
@@ -9011,7 +9011,7 @@ app.post('/upload', [checkCookieToken, multer({ dest: '/tmp', limits: internals.
       res.status(500);
       res.write('<b>Upload command failed:</b><br>');
     }
-    res.write(cmd);
+    res.write(safeStr(cmd));
     res.write('<br>');
     res.write('<pre>');
     res.write(stdout);

diff --git a/viewer/vueapp/src/components/spiview/Spiview.vue b/viewer/vueapp/src/components/spiview/Spiview.vue
@@ -1082,8 +1082,7 @@ export default {
         if (this.categoryObjects.hasOwnProperty(key)) {
           let category = this.categoryObjects[key];
 
-          let fields = category.fields;
-          fields = this.sortFields(category.fields);
+          let fields = this.sortFields(category.fields);
           Vue.set(category, 'filteredFields', fields);
 
           if (localStorage && localStorage['spiview-collapsible']) {

diff --git a/wiseService/wiseSource.js b/wiseService/wiseSource.js
@@ -276,11 +276,7 @@ WISESource.combineResults = function (results) {
   return buf;
 };
 // ----------------------------------------------------------------------------
-WISESource.result2Str = function (result, indent) {
-  if (!indent) {
-    indent = '';
-  }
-
+WISESource.result2Str = function (result) {
   let collection = [];
   var offset = 1;
   for (var i = 0; i < result[0]; i++) {