fix most jshint warnings

wiseService/.jshintrc

@@ -11,5 +11,6 @@
   "undef": true,
   "strict": true,
   "trailing": true,
-  "esversion": 6
+  "esversion": 6,
+  "validthis":true
 }

wiseService/source.elasticesearch.js

@@ -44,8 +44,9 @@ function ElasticsearchSource (api, section) {
     }
   });
 
-  if (!this.type)
+  if (!this.type) {
     return;
+  }
 
   this[this.api.funcName(this.type)] = this.sendResult;
 

wiseService/source.opendns.js

@@ -127,14 +127,15 @@ OpenDNSSource.prototype.performQuery = function () {
         console.log(this.section, "Error parsing for request:\n", postData, "\nresponse:\n", response);
         results = {};
       }
+
       for (var result in results) {
-        var cbs = this.processing[result];
+        let cbs = this.processing[result];
         if (!cbs) {
           return;
         }
         delete this.processing[result];
 
-        var args = [this.statusField, this.statuses[results[result].status]];
+        let args = [this.statusField, this.statuses[results[result].status]];
 
         if (results[result].security_categories) {
           results[result].security_categories.forEach((value) => {
@@ -158,7 +159,7 @@ OpenDNSSource.prototype.performQuery = function () {
 
         result = {num: args.length/2, buffer: wiseSource.encode.apply(null, args)};
 
-        var cb;
+        let cb;
         while ((cb = cbs.shift())) {
           cb(null, result);
         }

wiseService/source.reversedns.js

@@ -17,12 +17,12 @@
  */
 'use strict';
 
-var dns            = require('dns')
+var Dns            = require('dns')
   , iptrie         = require('iptrie')
   , wiseSource     = require('./wiseSource.js')
   , util           = require('util')
   ;
-var resolver       = dns;
+var resolver       = Dns;
 //////////////////////////////////////////////////////////////////////////////////
 function removeArray(arr, value) {
   var pos = 0;
@@ -38,7 +38,7 @@ function ReverseDNSSource (api, section) {
   this.ips          = api.getConfig("reversedns", "ips");
   this.servers      = api.getConfig("reversedns", "servers");
   if (this.servers !== undefined) {
-    resolver = new Resolver();
+    resolver = new Dns();
     resolver.setServers(this.servers.split(";"));
   }
   this.stripDomains = removeArray(api.getConfig("reversedns", "stripDomains", "").split(";").map(item => item.trim()), "");

wiseService/sprintf.js

@@ -62,7 +62,7 @@ exports.sprintf = function() {
 
   // formatString()
   var formatString = function (value, leftJustify, minWidth, precision, zeroPad, customPadChar) {
-    if (precision != null) {
+    if (precision !== null) {
       value = value.slice(0, precision);
     }
     return justify(value, '', leftJustify, minWidth, zeroPad, customPadChar);
@@ -76,7 +76,7 @@ exports.sprintf = function() {
     var textTransform;
     var value;
 
-    if (substring == '%%') {
+    if (substring === '%%') {
       return '%';
     }
 
@@ -114,9 +114,9 @@ exports.sprintf = function() {
     // we want to ignore null, undefined and empty-string values
     if (!minWidth) {
       minWidth = 0;
-    } else if (minWidth == '*') {
+    } else if (minWidth === '*') {
       minWidth = +a[i++];
-    } else if (minWidth.charAt(0) == '*') {
+    } else if (minWidth.charAt(0) === '*') {
       minWidth = +a[minWidth.slice(1, -1)];
     } else {
       minWidth = +minWidth;
@@ -133,10 +133,10 @@ exports.sprintf = function() {
     }
 
     if (!precision) {
-      precision = 'fFeE'.indexOf(type) > -1 ? 6 : (type == 'd') ? 0 : undefined;
-    } else if (precision == '*') {
+      precision = 'fFeE'.indexOf(type) > -1 ? 6 : (type === 'd') ? 0 : undefined;
+    } else if (precision === '*') {
       precision = +a[i++];
-    } else if (precision.charAt(0) == '*') {
+    } else if (precision.charAt(0) === '*') {
       precision = +a[precision.slice(1, -1)];
     } else {
       precision = +precision;

wiseService/wiseCache.js

@@ -19,8 +19,8 @@
 
 var LRU = require('lru-cache')
   , redis = require('redis')
-  , bson = require('bson')
-  , BSON = new bson()
+  , Bson = require('bson')
+  , BSON = new Bson()
   ;
 
 

wiseService/wiseService.js

@@ -530,7 +530,7 @@ function processQueryResponse0(req, res, queries, results) {
 //////////////////////////////////////////////////////////////////////////////////
 //
 function processQueryResponse2(req, res, queries, results) {
-  var hashes = (req.query.hashes || "").split(",")
+  var hashes = (req.query.hashes || "").split(",");
 
   const sendFields = !hashes.includes(internals.fieldsMd5);