[#10] Feat: 페이지 및 라우팅 세팅 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-na0
reviewed
Jan 3, 2024
src/routes/router.tsx
Outdated
| path: "/", | ||
| element: <Home />, | ||
| errorElement: <NotFound />, | ||
| }, |
There was a problem hiding this comment.
root path 밑의 경로는 children 배열로 관리해줘도 좋을 것 같습니다~
src/routes/router.tsx
Outdated
| errorElement: <NotFound />, | ||
| }, | ||
| { | ||
| path: "/search", |
There was a problem hiding this comment.
path는 상수로 관리해주는게 좋을 것 같습니다!
https://www.notion.so/1-058f752166234bf9aac5b46115af45f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close #10
⛳️ Task
페이지 및 라우팅 세팅
✍️ Note
각 페이지별 쿼리스트링등은 세팅하지는 않았습니다 . router.tsx에서 맡으신 페이지 각자 변경하셔도 됩니다.
📸 Screenshot
📎 Reference