fix: remove show done message if no files are generated

[alex-gilin]

Implements: #844

Additional logic to check if no files generated and targetPath is null,
doGeneratorDone empty string passed for message. No pop-up.

[martinjanus-sap]

Approach verified and tested with UI Service Generator:

No longer containing The files have been generated message when there are no files generated:

Thanks @alex-gilin

[martinjanus-sap]

Further testing:

Issue, not displaying pop-up in BAS when generating and path is /home/user/ ?

VSCODE:

• Ui Service Gen ✅:
  

• Fiori Gen through App Wizard ✅:
  

• Fiori Gen through command Palette ✅:
  

• Fiori: Open Reusable Library Generator ✅:
  

• Fiori: Add Reference to SAP Fiori Reusable Libraries ❓:
  no popup - but I think this is expected, as no files are generated.

• Fiori: Add Deployment Configuration: ❓
  no popup - although ui5-deploy.yaml is generated within project folder.

BAS:

• Fiori Gen through command Palette - /home/user/projects/: ✅
  

• Fiori Gen through command palette - /home/user/ ❓
  no pop-up

• Fiori Gen through App Wizard - /home/user/projects/ ✅
  

• Fiori: Open Reusable Library Generator ✅:
  

• Fiori: Add Reference to SAP Fiori Reusable Libraries ❓:
  no popup - but I think this is expected, as no files are generated.

• Fiori: Add Deployment Configuration: ❓
  no popup - although ui5-deploy.yaml is generated within project folder.

• Fiori Ui Service Generator: ✅
  

When running Fiori Generator on path /home/user/ in BAS, home directory in BAS is set as home/user/projects -
Relevant code:
https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/utils/constants.ts#L8
https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/yeomanui.ts#L354-L362
https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/yeomanui.ts#L203
Since targetFolder in SBAS is always set to home/user/projects , the logic comparing files generated before and after if it is not in home/user/projects will be 0 and pop-up message is not shown

[alex-gilin]

Further testing:

Issue, not displaying pop-up in BAS when generating and path is /home/user/ ?

VSCODE:

• Ui Service Gen ✅:
  
• Fiori Gen through App Wizard ✅:
  
• Fiori Gen through command Palette ✅:
  
• Fiori: Open Reusable Library Generator ✅:
  

BAS:

• Fiori Gen through command Palette - /home/user/projects/: ✅
  
• Fiori Gen through command palette - /home/user/ ❓
  no pop-up

When running Fiori Generator on path /home/user/ in BAS, home directory in BAS is set as home/user/projects - Relevant code: https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/utils/constants.ts#L8 https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/yeomanui.ts#L354-L362 https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/yeomanui.ts#L203 Since targetFolder in SBAS is always set to home/user/projects , the logic comparing files generated before and after if it is not in home/user/projects will be 0 and pop-up message is not shown

YUI is not guess to the specific execution details of individual generators, as this information is internal to each generator's logic. BAS does provide best practice guidelines that specify a default target directory for generator output. It's worth noting that users can easily modify this parameter through the ApplicationWizard.TargetFolder setting. In my opinion, if a user chooses not to follow the BAS recommendations, it doesn't pose a significant issue.