Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Cypress tests for Dialog #10629

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: add Cypress tests for Dialog #10629

wants to merge 4 commits into from
+286 −0

Conversation

LidiyaGeorgieva
Copy link
Contributor

Jira: BGSOFUIRODOPI-3347

@LidiyaGeorgieva
chore: add Cypress tests for Dialog
094ac5a 
Jira: BGSOFUIRODOPI-3347
@LidiyaGeorgieva LidiyaGeorgieva requested a review from a team January 22, 2025 14:41
nnaydenow
nnaydenow reviewed Jan 22, 2025
View reviewed changes
packages/main/cypress/specs/Dialog.cy.ts Outdated Show resolved Hide resolved
packages/main/cypress/specs/Dialog.cy.ts Outdated Show resolved Hide resolved
packages/main/cypress/specs/Dialog.cy.ts Outdated Show resolved Hide resolved
packages/main/cypress/specs/Dialog.cy.ts Outdated Show resolved Hide resolved
packages/main/cypress/specs/Dialog.cy.ts Outdated Show resolved Hide resolved
nnaydenow
nnaydenow reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, all tests should be written without setTimeouts and cy.wait

@LidiyaGeorgieva
Copy link
Contributor Author

Generally, all tests should be written without setTimeouts and cy.wait

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow left review comments

@ilhan007 ilhan007 ilhan007 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LidiyaGeorgieva @ilhan007 @nnaydenow