Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-table): migrate TableNavigation wdio tests to cypress #10620

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(ui5-table): migrate TableNavigation wdio tests to cypress #10620

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64e391c
chore(ui5-table): migrate TableNavigation wdio tests to cypress
nowakdaniel Jan 22, 2025
e9b9fd9
chore(ui5-table): deleted comment
nowakdaniel Jan 29, 2025
599cf9f
Merge branch 'main' into chore-tablenav-cypress
nowakdaniel Feb 10, 2025
c658054
fix: changed *.ts to *.tsx file extension and removed lit-html
nowakdaniel Feb 10, 2025
9f2115f
chore: moved reused alias to beforeEach + removed unused alias
nowakdaniel Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
339 changes: 339 additions & 0 deletions packages/main/cypress/specs/TableNavigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,339 @@
import { html } from "lit";
nowakdaniel marked this conversation as resolved.
Show resolved Hide resolved

import "../../src/Table.js";
import "../../src/TableHeaderRow.js";
import "../../src/TableHeaderCell.js";
import "../../src/TableRow.js";
import "../../src/TableCell.js";
import "../../src/TableGrowing.js";

describe("Table - Keyboard Navigation", () => {
beforeEach(() => {
cy.mount(html`
<input id="before-table1" type="number" value="0">
<ui5-table id="table0">
<ui5-table-growing id="growing" type="Button" slot="features"></ui5-table-growing>
<ui5-table-header-row slot="headerRow">
<ui5-table-header-cell><a id="row0-link" href="test.html">Link</a></ui5-table-header-cell>
<ui5-table-header-cell>Header2</ui5-table-header-cell>
<ui5-table-header-cell>Header3</ui5-table-header-cell>
<ui5-table-header-cell>Header4</ui5-table-header-cell>
</ui5-table-header-row>
<ui5-table-row>
<ui5-table-cell>Row1Cell0</ui5-table-cell>
<ui5-table-cell><input id="row1-input"></ui5-table-cell>
<ui5-table-cell><button id="row1-button">Button 1</button></ui5-table-cell>
<ui5-table-cell>Row1Cell3</ui5-table-cell>
</ui5-table-row>
<ui5-table-row id="interactive-row" interactive>
<ui5-table-cell>Row2Cell0</ui5-table-cell>
<ui5-table-cell><input id="row2-input"></ui5-table-cell>
<ui5-table-cell><button id="row2-button">Button 2</button></ui5-table-cell>
<ui5-table-cell>Row2Cell3</ui5-table-cell>
</ui5-table-row>
<ui5-table-row id="notinteractive-row"> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell> Here the table structure is broken. There is only one cell in row 5. </ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
<ui5-table-row> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> <ui5-table-cell></ui5-table-cell> </ui5-table-row>
</ui5-table>
<input id="after-table1">
`);

cy.document().then(doc => {
const table = doc.getElementById("table0");
const input = doc.getElementById("before-table1");
table?.addEventListener("ui5-row-click", () => {
if (input instanceof HTMLInputElement) {
input.valueAsNumber++;
}
});
});
});

function getCell(row: number, cell: number, headerRow: boolean) {
if (headerRow) {
return cy.get("@headerRow").children("ui5-table-header-cell").eq(cell);
}
return cy.get("@rows").eq(row)
.children("ui5-table-cell")
.eq(cell);
}

it("should navigate on rows", () => {
cy.get("#table0").children("ui5-table-row").as("rows");
cy.get("#table0").children("ui5-table-header-row").as("headerRow");

cy.get("@rows").eq(0)
// left click is needed to focus the row
// otherwise the it would click in the center of the row where an input is
// resulting in a focus on the input instead of the row
.click("left");
cy.get("@rows").eq(0).should("be.focused")

.type("{leftarrow}");
cy.get("@rows").eq(0).should("be.focused")

.type("{uparrow}");
cy.get("@headerRow").should("be.focused")

.type("{uparrow}");
cy.get("@headerRow").should("be.focused")

.type("{downarrow}{downarrow}");
cy.get("@rows").eq(1).should("be.focused")

.type("{pagedown}");
cy.get("@rows").eq(21).should("be.focused")

.type("{pagedown}");
cy.get("@rows").eq(24).should("be.focused")

.type("{pagedown}");
cy.get("#growing").shadow().find("#growing-button").should("be.focused")

.type("{pageup}");
cy.get("@rows").eq(5).should("be.focused")

.type("{pageup}");
cy.get("@rows").eq(0).should("be.focused")

.type("{end}");
cy.get("@rows").eq(24).should("be.focused")

.type("{end}");
cy.get("#growing").shadow().find("#growing-button").should("be.focused")

.type("{home}");
cy.get("@rows").eq(0).should("be.focused")

.type("{home}");
cy.get("@headerRow").should("be.focused");
});

it("should navigate on cells", () => {
cy.get("#table0").children("ui5-table-row").as("rows");
cy.get("#table0").children("ui5-table-header-row").as("headerRow");

cy.get("@rows").eq(0)
.click("left");

cy.get("@rows").eq(0).should("be.focused")

.type("{rightarrow}");
getCell(0, 0, false).should("be.focused")

.type("{leftarrow}");
cy.get("@rows").eq(0).should("be.focused")

.type("{rightarrow}{rightarrow}");
getCell(0, 1, false).should("be.focused")

.type("{home}");
getCell(0, 0, false).should("be.focused")

.type("{end}");
getCell(0, 3, false).should("be.focused")

.type("{rightarrow}");
getCell(0, 3, false).should("be.focused")

.type("{end}");
cy.get("@rows").eq(0).should("be.focused")

.type("{end}");
cy.get("@rows").eq(24).should("be.focused")

.type("{rightarrow}{rightarrow}{rightarrow}");
getCell(24, 2, false).should("be.focused")

.type("{pageup}");
getCell(4, 0, false).should("be.focused")

.type("{pageup}");
getCell(0, 0, false).should("be.focused")

.type("{pageup}");
getCell(0, 0, true).should("be.focused")

.type("{pagedown}");
getCell(19, 0, false).should("be.focused")

.type("{pagedown}");
getCell(24, 0, false).should("be.focused")

.type("{pagedown}");
cy.get("#growing").shadow().find("#growing-button").should("be.focused")

.type("{home}");
cy.get("@rows").eq(0).should("be.focused")

.type("{home}");
cy.get("@headerRow").should("be.focused");

cy.get("@headerRow").type("{downarrow}{rightarrow}");

// differs from originial test where condition was i < 4
// changed due to cy.type after last assertion
// TBD just a reminder for reviewers
nowakdaniel marked this conversation as resolved.
Show resolved Hide resolved
for (let i = 0; i < 3; i++) {
getCell(i, i, false).should("be.focused")
.type("{downarrow}{rightarrow}");
}

getCell(3, 3, false).should("be.focused")
.type("{downarrow}");

getCell(4, 0, false).should("be.focused");
});

it("should handle F2/F7/Enter/Tab/Up/Down", () => {
cy.get("#table0").children("ui5-table-row").as("rows");
cy.get("#table0").children("ui5-table-header-row").as("headerRow");
cy.get("@headerRow").get("#row0-link").as("row0Link");
cy.get("@rows").eq(0).get("#row1-input").as("row1Input");
cy.get("@rows").eq(0).get("#row1-button").as("row1Button");
cy.get("@rows").eq(1).get("#row2-input").as("row2Input");
cy.get("@rows").eq(1).get("#row2-button").as("row2Button");

cy.get("@rows").eq(0).click("left");
cy.get("@rows").eq(0).should("be.focused");

cy.get("@rows").eq(0).realPress("F2");
cy.get("@row1Input").eq(0).should("be.focused")

.realPress("F2");
getCell(0, 1, false).should("be.focused")

.realPress("F2");
cy.get("@row1Input").eq(0).should("be.focused")

.realPress("F7");
cy.get("@rows").eq(0).should("be.focused")

.realPress("F7");
cy.get("@row1Input").eq(0).should("be.focused")

.type("{downarrow}");
cy.get("@row1Input").eq(0).should("be.focused")

.type("{uparrow}");
cy.get("@row1Input").eq(0).should("be.focused")

.realPress(["F2", "{uparrow}"]);
getCell(0, 1, true).should("be.focused")

.realPress("F2");
getCell(0, 1, true).should("be.focused")

.type("{leftarrow}");
getCell(0, 0, true).should("be.focused")

.type("{enter}");
cy.get("@row0Link").should("be.focused")

.type("{downarrow}");
getCell(0, 0, false).should("be.focused")

.realPress("Tab");
cy.get("#after-table1").should("be.focused")

.realPress(["Shift", "Tab"]);
cy.get("@rows").eq(0).should("be.focused")

.type("{downarrow}");
cy.get("@rows").eq(1).should("be.focused")

.realPress("F7");
cy.get("@row2Input").eq(0).should("be.focused")

.realPress("Tab");
cy.get("@row2Button").should("be.focused")

.realPress("F7");
cy.get("@rows").eq(1).should("be.focused")

.type("{uparrow}");
cy.get("@rows").eq(0).should("be.focused")

.realPress("F7");
cy.get("@row1Button").eq(0).should("be.focused")

.type("{uparrow}");
getCell(0, 2, true).should("be.focused")

.realPress("F7");
cy.get("@headerRow").should("be.focused")

.type("{downarrow}");
cy.get("@rows").eq(0).should("be.focused")

.realPress("F7");
getCell(0, 2, false).should("be.focused")

.realPress("F7");
cy.get("@rows").eq(0).should("be.focused")

.type("{downarrow}");
cy.get("@rows").eq(1).should("be.focused")

.realPress("F7");
getCell(1, 2, false).should("be.focused")

.realPress(["Shift", "Tab"]);
cy.get("#before-table1").should("be.focused")

.realPress("Tab");
cy.get("@rows").eq(1).should("be.focused");
});

it("should should work correctly for interactive rows", () => {
cy.get("#table0").children("ui5-table-row").as("rows");
cy.get("@rows").eq(1).get("#row2-button").as("row2Button");
cy.get("#table0").get("#before-table1").as("input");
cy.get("@rows").get("#interactive-row").as("row");
cy.get("@rows").get("#notinteractive-row").as("anotherRow");

cy.get("@row").click("left");
cy.get("@input").should("have.value", "1");

cy.get("@row").type("{enter}");
cy.get("@input").should("have.value", "2");

cy.get("@anotherRow").click("left");
cy.get("@input").should("have.value", "2");

cy.get("@row2Button").click("left");
cy.get("@input").should("have.value", "2");

cy.get("@row2Button").type("{enter}");
cy.get("@input").should("have.value", "2");

cy.get("@row2Button").realPress("F7");
cy.get("@row").should("be.focused");

cy.get("@row").realPress("Space");
cy.get("@input").should("have.value", "2");

cy.get("@row").type("{enter}");
cy.get("@input").should("have.value", "3");
});
});
Loading