Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-dynamic-page): prevent scroll position reset on unpinning the header #10441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-dynamic-page): prevent scroll position reset on unpinning the header #10441

wants to merge 1 commit into from

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Dec 23, 2024 •
edited
Loading

Issue:

  • When header was pinned before scrolling, unpinning would reset scroll position due to incorrect sticky area state.

Solution:

  • Set sticky area to true on pin to preserve scroll state.

Fixes: #10440

@NakataCode NakataCode marked this pull request as ready for review December 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-dynamic-page]: Pinned header before scroll
1 participant
@NakataCode