feat(ui5-dynamic-side-content): add customizable aria labels #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the Dynamic Side Content component (
<ui5-dynamic-side-content>) hadrolewith value complementary and fixed translatablearia-labelonly for its Side Content area.With this PR is intruduced new property
accessibilityAttributesthat can be used for setting of customaria-labeltexts for both Main Content and Side Content areas. Also, aroleattribute with value main and a fixed translatable label is provided for the Main Content as a fallback if there is no custom label defined.There are tests added for the new feature.
Fixes: #8612