Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-side-navigation): update existing design for Horizon theme #10337

Merged
merged 15 commits into from
Jan 14, 2025
Merged

feat(ui5-side-navigation): update existing design for Horizon theme #10337

merged 15 commits into from
Jan 14, 2025

Conversation

LidiyaGeorgieva
Copy link
Contributor

This redesign is related to Visual Alignment UXC 026

Jira: BGSOFUIRODOPI-3342

@LidiyaGeorgieva
feat(ui5-side-navigation): update existing design for Horizon theme
b2270fd 
This redesign is related to Visual Alignment UXC 026

Jira: BGSOFUIRODOPI-3342
Stoev
Stoev reviewed Dec 9, 2024
View reviewed changes
Copy link

@Stoev Stoev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from UA perspective.

@LidiyaGeorgieva LidiyaGeorgieva requested a review from a team December 16, 2024 15:42
GerganaKremenska
GerganaKremenska reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@GerganaKremenska GerganaKremenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Child item text and parent item text should be aligned view in VD "Child Item" expanded
  2. When expanding and collapsing the "Icon with navigation arrow" transitions aways visible in openui5 is better
  3. Icon Only (collapsed) should be 16px, no is 18 px

packages/fiori/src/themes/sap_horizon/SideNavigation-parameters.css Show resolved Hide resolved
@LidiyaGeorgieva LidiyaGeorgieva merged commit d5eff51 into main Jan 14, 2025
10 checks passed
@LidiyaGeorgieva LidiyaGeorgieva deleted the ui5-side-navigation-horizon-design-update branch January 14, 2025 13:25
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.0 🎉

The release is available on v2.7.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@GerganaKremenska GerganaKremenska GerganaKremenska approved these changes

@kskondov kskondov Awaiting requested review from kskondov

@TeodorTaushanov TeodorTaushanov Awaiting requested review from TeodorTaushanov

@dimovpetar dimovpetar Awaiting requested review from dimovpetar

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LidiyaGeorgieva @ui5-webcomponents-bot @Stoev @GerganaKremenska