-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-color-picker): add HSL color selection #10157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the following bug:
- Change to HSL mode from the button
- Input 30 for H press Tab
- Input 20 for S press Enter
Expected:
The values in the sliders and in the gradient field are updated according to the lastly entered saturation value.
If your starting color is HSL 0, 0, 100, Changing the hue from the input should update the hue slider to around orange, but since the light is still 100, no matter what you set the saturation or hue to, the color will still be white, so the main color picker wont get updated. |
My point is that even if the main color doesn't change those interactions from the openui5 project do reflect the input values with more detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the messagebundle.properties file please consider changing "Aria" to "ARIA".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to stick with original description.
This change introduces the ability to select colors using HSL channels. Users can now toggle between viewing color values as RGB or HSL by selecting the↔️ button.
Fixes: #10275